fix(sv): stricter logic for rune mode#991
Merged
jycouet merged 6 commits intosveltejs:mainfrom Mar 20, 2026
Merged
Conversation
🦋 Changeset detectedLatest commit: ee1f993 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
sacrosanctic
changed the title
commit: |
Member
|
We might want to wait for sveltejs/svelte#17951 to be released, so that we can make the changes in the correct place as well |
manuel3108
approved these changes
Mar 20, 2026
Member
|
Looks fine to me and work, would like a review from @jycouet as well, since he was part of the initial implementation if i remember correctly. Should also solve the issue Jeppe (storybook) reported |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#987
code sourced from #987 (comment)
Also add a comment to remove it in svelte 6