Automatically reset form with use:enhance

[hanszoons]

Describe the bug

Without an argument, use:enhance will emulate the browser-native behaviour, just without the full-page reloads.

Native browser behaviour clears form inputs after submit (or rather the associated page reload does that).

The progressively enhanced forms do not. This would require resetting the form in the enhance callback. This works:

<form
	method="post"
	action="?/doSomething"
	use:enhance={({ form }) => {
		return async ({ update }) => {
			form.reset();
			await update();
		};
	}}
>

But is still a hassle.

Reproduction

This applies to all SvelteKit installs.

Logs

No response

System Info

System:
    OS: macOS 12.6
    CPU: (10) arm64 Apple M1 Pro
    Memory: 7.58 GB / 32.00 GB
    Shell: 5.8.1 - /bin/zsh
  Binaries:
    Node: 18.9.0 - ~/.nvm/versions/node/v18.9.0/bin/node
    npm: 8.19.1 - ~/.nvm/versions/node/v18.9.0/bin/npm
  Browsers:
    Chrome: 105.0.5195.125
    Firefox: 105.0.1
    Safari: 16.0
  npmPackages:
    @sveltejs/adapter-auto: ^1.0.0-next.76 => 1.0.0-next.80 
    @sveltejs/adapter-node: ^1.0.0-next.96 => 1.0.0-next.96 
    @sveltejs/adapter-vercel: ^1.0.0-next.77 => 1.0.0-next.77 
    @sveltejs/kit: ^1.0.0-next.489 => 1.0.0-next.507 
    svelte: ^3.50.1 => 3.50.1 
    vite: ^3.1.4 => 3.1.4

Severity

annoyance

Additional Information

No response

[Conduitry]

I'm assuming we'd only want this to reset for successful submits, and not ones that did throw invalid(400, whatever)?

Separately, I'm not really comfortable calling this an "enhancement". It's a user-noticeable change in default behavior without (I'm assuming) them needing to specify any other options. If we want the default behavior to change, then either we need to consider the current behavior a bug, or this change would be a breaking change.

[williamviktorsson]

I would consider it more of a bug than a missing feature. I find myself adding the ({form})=>form.reset() all over the place to make it feel more like the enhance really just enhanced the experience rather than alter it.

I’d argue that if users want a different behavior with javascript enabled, maybe they could write something like ({form})=>form.save()

[ZetiMente]

@williamviktorsson Agreed ! Was surprised when I first tried using form actions that it didn't reset after submit.