don't throw if `ADDRESS_HEADER` is absent in `adapter-node`

[ivanhofer]

Describe the problem

Not all requests will have the header specified. E.g. on render.com when doing a health-check the service does an internal request. This will crash the server because the header is not present.

Describe the proposed solution

Get rid of this code: https://github.com/ivanhofer/kit/blob/export-SubmitFunction/packages/adapter-node/src/handler.js#L94-L100

This would be a breaking change as someone might rely on this error.

An option would also be to make this error throw configurable via an adapter option.

Alternatives considered

Require users to patch the getClientAddress functionality by themself.

As a workaround I currently do this in the first line of the handle function:

event.getClientAddress = () => request.headers.get('cf-connecting-ip')

Importance

would make my life easier

Additional Information

No response

[Conduitry]

This makes me uneasy. If you're on a system that doesn't always send the appropriate headers, the right solution to me feels like to write a custom server entrypoint that massages the incoming request before passing it along, not removing this check.

[Blackwidow-sudo]

Man i debugged for 2 days to find this out.
Im using coolify (which uses traefik as a proxy) and have a healthcheck running which always crashes the app because the docker healthchecks are not routed through traefik.

I totally agree that there should be a way to handle the thrown error. This is annoying 😭
I dont know what i should do in the meantime...i could add --header="X-Forwarded-For: healthcheck" to my healthcheck, but that doesn't seem to be a good solution...