-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
docs: .nojekyll in static folder. #11566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Can you elaborate on why this only applies if you're not using the suggested workflow? (I don't use GitHub Pages so I don't really understand its significance — would it be simpler to just recommend that people always add |
|
Hi @Rich-Harris, of course. When the build file is in a separate GitHub repository from the source Svelte code repository. For instance, this repo (by me), that shares the built code without sharing the source svelte code (private github repo). See the github page result here. That build repo is a Github submodule of my original svelte repository which obviously you can't see. The build repo is static In this case, you should not have a workflow, but you should have a |
Co-authored-by: Rich Harris <hello@rich-harris.dev>
|
Got it, thanks. I moved the comment beneath the code snippet, since it's weird to say 'use this workflow (if you're not using the workflow, do this), here's the workflow' |
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits
Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.
adding the following instruction: make sure
.nojekyllexists without the github page config.My note: the
.nojekyllinstruction is missing in #10083. People that do not use custom github pages config will be confused (like me). I read that before, and I noticed that the instruction is missing. Moreover, people debugging will read this very popular thread and get mislead because the instruction to add.nojekyllis missing.