Skip to content

Conversation

@SrGeneroso
Copy link
Contributor

Add some missing properties for the correct creation of href for the first items of "On this page" component of the Sveltekit Docs. Currently doesn't create that reference in the first item and prevent navigation to the top of the page.

More info on issue


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check
    Only affects website

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

🥹Junior dev PR

I'm not sure how to do that. I've done it manually and I hope is done properly.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

Copy link
Contributor

@PuruVJ PuruVJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@ghostdevv ghostdevv merged commit 3d82b9c into sveltejs:main Feb 13, 2024
@ghostdevv ghostdevv added the documentation Improvements or additions to documentation label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants