Skip to content

Conversation

@bluepuma77
Copy link

The current text "Defaults to 512kb" implies, that this is the way to set the variable. But it needs to be numeric, no unit.

Note: first pull request ever 🙂


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Feb 16, 2024

⚠️ No Changeset found

Latest commit: 128e380

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann benmccann changed the title Make clear that BODY_SIZE_LIMIT is set numeric with bytes, can not use "1024kb" docs: clarify that BODY_SIZE_LIMIT is numeric and does not accept '512kb' Feb 17, 2024
@benmccann benmccann added documentation Improvements or additions to documentation pkg:adapter-node labels Feb 17, 2024
Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com>
@benmccann
Copy link
Member

Note that if we moved forward with #11680 we would no longer need this PR

@benmccann
Copy link
Member

I merged #11680, so closing this PR

@benmccann benmccann closed this Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation pkg:adapter-node

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants