Skip to content

Conversation

@benmccann
Copy link
Member

@benmccann benmccann commented Jan 17, 2025

see sveltejs/cli#409. wait until that PR is merged. it is currently blocked on an issue in pnpm

@changeset-bot
Copy link

changeset-bot bot commented Jan 17, 2025

⚠️ No Changeset found

Latest commit: a6d3cc3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

preview: https://svelte-dev-git-preview-kit-13337-svelte.vercel.app/

this is an automated message

@benmccann benmccann marked this pull request as draft January 17, 2025 19:15
@teemingc teemingc added the documentation Improvements or additions to documentation label Jan 21, 2025
@teemingc
Copy link
Member

Do we need to also update the test suites to use preprepare? Currently, they use prepare.

@benmccann
Copy link
Member Author

Yes, good call. I've updated the test projects now

Copy link
Member

@Conduitry Conduitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As in sveltejs/cli#409, this will cause issues with npm ci --omit=dev. Once we sort out in that PR how we want to deal with this, we need to update this PR as well.

@benmccann benmccann closed this Jan 21, 2025
@benmccann benmccann deleted the preprepare branch January 21, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants