Skip to content

Conversation

@teemingc
Copy link
Member

@teemingc teemingc commented Feb 3, 2025

part of #13385

This PR removes the recommendation to configure the name of the _env.js file through the publicModule option since it doesn't exist. It also corrects the name of the public module file from _env.js to env.js (without the underscore) since that's the name the codebase actually uses.

https://github.com/search?q=repo:sveltejs/kit%20ir%7D/env.js&type=code


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2025

⚠️ No Changeset found

Latest commit: 61745d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot
Copy link

@teemingc teemingc changed the title docs: remove mention of publicModule option docs: remove mention of non-existent publicModule option Feb 3, 2025
@teemingc teemingc added the documentation Improvements or additions to documentation label Feb 3, 2025
@dummdidumm dummdidumm merged commit 9f8e950 into main Feb 3, 2025
13 checks passed
@dummdidumm dummdidumm deleted the eltigerchino-patch-1 branch February 3, 2025 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants