Skip to content

Conversation

@BD103
Copy link
Contributor

@BD103 BD103 commented Mar 11, 2025

On the SvelteKit Integrations page, the link to the FAQ page jumps to the "How do I set up a database?" header. This doesn't seem intentional, as the entire FAQ page is useful, not just the database section.

This PR fixes the link by making it go to the top of the page.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
    • Change is trivial, so it probably doesn't need an issue :)
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
    • This isn't something that can realistically be tested

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.
    • Change is trivial and shouldn't cause a version bump

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link

changeset-bot bot commented Mar 11, 2025

⚠️ No Changeset found

Latest commit: 7fcd66f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@BD103 BD103 changed the title Fix FAQ link from jumping to database section docs: fix faq link from jumping to database section Mar 11, 2025
@teemingc teemingc added the documentation Improvements or additions to documentation label Mar 12, 2025
@benmccann
Copy link
Member

thank you. there used to be another level of heading that was removed and I guess this link got incorrectly updated then

@benmccann benmccann merged commit 1b9daad into sveltejs:main Mar 14, 2025
14 checks passed
@BD103 BD103 deleted the fix-faq-link branch March 15, 2025 13:59
@BD103
Copy link
Contributor Author

BD103 commented Mar 15, 2025

thank you. there used to be another level of heading that was removed and I guess this link got incorrectly updated then

No problems, glad to help! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants