fix: fix RecursiveFormFields type for recursive or unknown schemas#14689
Closed
sillvva wants to merge 4 commits intosveltejs:mainfrom
Closed
fix: fix RecursiveFormFields type for recursive or unknown schemas#14689sillvva wants to merge 4 commits intosveltejs:mainfrom
RecursiveFormFields type for recursive or unknown schemas#14689sillvva wants to merge 4 commits intosveltejs:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 2f955c6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
RecursiveFormFields type for recursive or unknown schemasRecursiveFormFields type for recursive or unknown schemas
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
Author
|
Closed in favor of #14734 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #14687
Right now, if the schema is
unknownor otherwise indefinitely recursive, it treatsform.fieldsas a field leaf instead of a field container. This makesform.fields.as()incorrectly available instead ofform.fields.allIssues(). This update fixes that by ensuringform.fieldsis always treated as a field container.It also exports the
RemoteFormFieldstype so that it can be used to create wrapper components.Examples
Pretend the function is a generic component
Before Fix
After Fix
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits