Conversation
🦋 Changeset detectedLatest commit: 4089c23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| } | ||
| }; | ||
| if (is_rolldown && new_config.optimizeDeps) { | ||
| delete new_config.optimizeDeps.esbuildOptions; // vite 8 logs a warning when esbuildOptions is used |
There was a problem hiding this comment.
rather than deleting it, we should probably only add it if !is_rolldown
There was a problem hiding this comment.
refactored to nested conditionals for adding the plugins only when they are needed
|
tried bumping vite, vitest and playwright to latest versions and run kit tests but that requires some changes that are out of scope for this PR, recommending to keep it draft until deps are more up2date in this repo |
benmccann
changed the title
Rich-Harris
left a comment
Rich-Harris
left a comment
There was a problem hiding this comment.
blocking merge until after #15321
4 participants
vite 8 beta was released today and it logs a warning when esbuildOptions is used for the optimizer. vite-plugin-svelte already uses rolldown optimizer.
needs testing and maybe a refactor to move the esbuild and rolldown plugins closer together. Right now its not really great for readability but its temporal because we can drop the esbuild plugin altogether when vite8 is lowest supported version.
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits