Skip to content

fix: avoid inlineDynamicImports deprecated option warning when using Vite 8#15550

Merged
benmccann merged 3 commits intomainfrom
fix-vite8-warning
Mar 16, 2026
Merged

fix: avoid inlineDynamicImports deprecated option warning when using Vite 8#15550
benmccann merged 3 commits intomainfrom
fix-vite8-warning

Conversation

@teemingc
Copy link
Member

@teemingc teemingc commented Mar 16, 2026

closes #15549

This PR avoids setting inlineDynamicImports when Rolldown/Vite 8 is used so that we don't get a deprecated option message when building the service worker. This is already fixed in the version-3 branch.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@teemingc teemingc added the vite label Mar 16, 2026
@changeset-bot
Copy link

changeset-bot bot commented Mar 16, 2026

🦋 Changeset detected

Latest commit: af82b7d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

// versions throw an error about unknown config options
if (is_rolldown && config?.build?.rollupOptions?.output) {
// @ts-ignore only available in Vite 8
new_config.build.rollupOptions.output.codeSplitting = split;
Copy link
Contributor

@vercel vercel bot Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Service worker build incorrectly enables code splitting with Rolldown, breaking the single-file requirement for service workers.

Fix on Vercel

@benmccann benmccann merged commit 5e34a8c into main Mar 16, 2026
29 checks passed
@benmccann benmccann deleted the fix-vite8-warning branch March 16, 2026 21:29
@github-actions github-actions bot mentioned this pull request Mar 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecation warning when building on Vercel with Vite 8 (build_service_worker.js)

2 participants