Skip to content

breaking: move adapter to vite.config.js#15780

Merged
teemingc merged 16 commits into
fetchable-dev-environmentfrom
move-adapter-to-vite-config
Apr 30, 2026
Merged

breaking: move adapter to vite.config.js#15780
teemingc merged 16 commits into
fetchable-dev-environmentfrom
move-adapter-to-vite-config

Conversation

@teemingc
Copy link
Copy Markdown
Member

@teemingc teemingc commented Apr 30, 2026

Addresses #15574 (comment)

This PR make the necessary changes to the docs, test apps, and kit code to warns users to move their adapter to the vite config file.


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

teemingc and others added 5 commits April 30, 2026 05:15
Co-authored-by: Copilot <copilot@github.com>
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 30, 2026

🦋 Changeset detected

Latest commit: 776e1b9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@teemingc teemingc requested a review from Rich-Harris April 30, 2026 07:51
@svelte-docs-bot
Copy link
Copy Markdown

@teemingc
Copy link
Copy Markdown
Member Author

Site deployment is failing because we probably need to move the adapter to the vite config. But I can't do that and get the check passing because it pulls the main site branch on commit

Comment thread packages/kit/src/core/config/options.js Outdated
Comment thread packages/kit/src/exports/vite/options.js Outdated
Comment thread documentation/docs/25-build-and-deploy/20-adapters.md
Copy link
Copy Markdown
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of v minor style nits but LGTM

teemingc and others added 4 commits April 30, 2026 23:04
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>
@teemingc teemingc merged commit f490f88 into fetchable-dev-environment Apr 30, 2026
18 of 19 checks passed
@teemingc teemingc deleted the move-adapter-to-vite-config branch April 30, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants