breaking: remove adapter.emulate#15845
Conversation
🦋 Changeset detectedLatest commit: 31ce356 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| /** | ||
| * A collection of functions that influence the environment during dev, build and prerendering | ||
| */ | ||
| export interface Emulator { |
There was a problem hiding this comment.
Wonder if we should keep this but add the @deprecated tag so that it doesn't 404 in the docs 🤔
| import { record_span } from '../telemetry/record_span.js'; | ||
| import { otel } from '../telemetry/otel.js'; | ||
|
|
||
| /* global __SVELTEKIT_ADAPTER_NAME__ */ |
There was a problem hiding this comment.
This is unused and already declared in packages/kit/src/types/global-private.d.ts
| Of these, `name` and `adapt` are required. `supports` is optional. | ||
|
|
||
| > [!LEGACY] | ||
| > The `emulate` property was added in 2.5.0 but removed in 3.0.0. |
There was a problem hiding this comment.
Thought about adding a reason alongside the message here but it can be added when we add the Vite plugins option which replace it
|
I think this might be something we do want to do as part of #15574, because if for whatever reason we decided not to adopt the environment API, we would be left with no platform emulation capability at all |
|
Makes sense. I'll close this one then |
2 participants
closes #15672
Splits out the change from #15574
Please don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits