Conversation
|
teemingc
commented
May 15, 2026
| import { record_span } from '../telemetry/record_span.js'; | ||
| import { otel } from '../telemetry/otel.js'; | ||
|
|
||
| /* global __SVELTEKIT_ADAPTER_NAME__ */ |
Member
Author
There was a problem hiding this comment.
not in use and already declared in our global types file
teemingc
commented
May 15, 2026
| request: Request, | ||
| options: RequestOptions & { | ||
| prerendering?: PrerenderOptions; | ||
| read: (file: string) => NonSharedBuffer; |
Member
Author
There was a problem hiding this comment.
NonSharedBuffer is a deprecated type according to TypeScript
6 tasks
Rich-Harris
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
split out from #15574
This PR replaces our use of
als.enterWithwith the standardals.runbecauseenterWithis not standard in other runtimes such as workerd (it's an experimental node feature). This change requires wrapping our server response code in a function and running async local storage with that functionPlease don't delete this checklist! Before submitting the PR, please make sure you do the following:
Tests
pnpm testand lint the project withpnpm lintandpnpm checkChangesets
pnpm changesetand following the prompts. Changesets that add features should beminorand those that fix bugs should bepatch. Please prefix changeset messages withfeat:,fix:, orchore:.Edits