Skip to content

chore: add names for static adapter test apps#15851

Merged
benmccann merged 1 commit into
mainfrom
chore-static-test-app-name
May 17, 2026
Merged

chore: add names for static adapter test apps#15851
benmccann merged 1 commit into
mainfrom
chore-static-test-app-name

Conversation

@teemingc
Copy link
Copy Markdown
Member

Adding names for these test apps help them clearly show up in the logs when one of their tests fail


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 15, 2026

⚠️ No Changeset found

Latest commit: b1ac669

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@svelte-docs-bot
Copy link
Copy Markdown

@@ -1,5 +1,5 @@
{
"name": "~TODO~",
"name": "test-static-prerendered",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally I would put test at the end of these names so it reads more fluently like static-prerendered-test

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm but the other test apps all follow this convention already

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay. Nevermind then

@@ -1,5 +1,5 @@
{
"name": "~TODO~",
"name": "test-static-prerendered",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally I would put test at the end of these names so it reads more fluently like static-prerendered-test

@benmccann benmccann merged commit 268bac4 into main May 17, 2026
29 checks passed
@benmccann benmccann deleted the chore-static-test-app-name branch May 17, 2026 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants