Skip to content

fix: avoid generating _app/env.js if unused#15940

Merged
Rich-Harris merged 2 commits into
mainfrom
avoid-generating-env
Jun 2, 2026
Merged

fix: avoid generating _app/env.js if unused#15940
Rich-Harris merged 2 commits into
mainfrom
avoid-generating-env

Conversation

@teemingc
Copy link
Copy Markdown
Member

@teemingc teemingc commented Jun 1, 2026

closes #13551

We already have a condition that's false if the app doesn't use public dynamic environment variables. This PR uses that to avoid generating the file if so. This mostly affects the static adapter


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
    • no test unless we want to set up a new static adapter test app. The existing ones both use public dynamic env vars and test for it

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 1, 2026

🦋 Changeset detected

Latest commit: 54ee100

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@svelte-docs-bot
Copy link
Copy Markdown

@Rich-Harris Rich-Harris merged commit 600a388 into main Jun 2, 2026
29 checks passed
@Rich-Harris Rich-Harris deleted the avoid-generating-env branch June 2, 2026 02:20
This was referenced Jun 2, 2026
Rich-Harris pushed a commit that referenced this pull request Jun 2, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @sveltejs/kit@2.62.0

### Minor Changes

- feat: support passing Svelte(Kit) config via Vite plugin
([#15944](#15944))

### Patch Changes

- fix: preserve multiple `Set-Cookie` headers on 304 responses
([#15902](#15902))


- fix: preload for anchor elements that were just previously preloaded
([#15915](#15915))


- fix: catch load function streaming errors on the client
([#15929](#15929))


- fix: avoid generating the `_app/env.js` module if public dynamic
environment variables are not used by the app
([#15940](#15940))

## @sveltejs/package@2.5.8

### Patch Changes

- chore: bump `svelte2tsx` dependency to support TypeScript 6
([#15896](#15896))

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extra unused files are output with bundleStrategy: 'single'

2 participants