Skip to content

fix: use forward slashes in generated env.d.ts import path on Windows#15977

Merged
Rich-Harris merged 1 commit into
sveltejs:mainfrom
Nic-Polumeyv:fix-env-dts-windows-path
Jun 7, 2026
Merged

fix: use forward slashes in generated env.d.ts import path on Windows#15977
Rich-Harris merged 1 commit into
sveltejs:mainfrom
Nic-Polumeyv:fix-env-dts-windows-path

Conversation

@Nic-Polumeyv
Copy link
Copy Markdown
Contributor

@Nic-Polumeyv Nic-Polumeyv commented Jun 7, 2026

Fixes #15959.

write_env builds the path with path.relative, which returns backslashes on Windows. That value goes into an import('...') type in the generated env.d.ts, so the backslashes break module resolution and every explicit env var falls back to any. Wrapping it in posixify fixes it, the same way write_tsconfig already handles its relative paths.

The broken import degrades the types to any rather than erroring, which is probably why it slipped through Windows CI even though options-2 generates this file with explicitEnvironmentVariables enabled.

Changesets

  • patch changeset added

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jun 7, 2026

🦋 Changeset detected

Latest commit: a176b19

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/kit Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

`write_env` built the path with `path.relative`, which returns backslashes on
Windows. The path is interpolated into an `import('...')` type, where the
backslashes break module resolution and the env vars fall back to `any`. Wrap
it in `posixify`, matching how `write_tsconfig` already handles relative paths.

Fixes sveltejs#15959
@Nic-Polumeyv Nic-Polumeyv force-pushed the fix-env-dts-windows-path branch from 14da52c to a176b19 Compare June 7, 2026 19:39
Copy link
Copy Markdown
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@Rich-Harris Rich-Harris merged commit f57a4bc into sveltejs:main Jun 7, 2026
25 of 26 checks passed
This was referenced Jun 7, 2026
@Nic-Polumeyv Nic-Polumeyv deleted the fix-env-dts-windows-path branch June 8, 2026 00:03
Rich-Harris pushed a commit that referenced this pull request Jun 8, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @sveltejs/kit@2.63.1

### Patch Changes


- fix: use SSE for `query.live`
([#15957](#15957))


- fix: use forward slashes in the generated `env.d.ts` import path on
Windows ([#15977](#15977))


- fix: allow `$app/environment` with a warning when
`explicitEnvironmentVariables` is enabled
([#15980](#15980))


- fix: avoid importing Vite while validating explicit environment
variables ([#15953](#15953))


- docs: adjust the release version of explicit env vars
([#15968](#15968))


- fix: ensure `version` is defined when importing from `$app/env` with
explicit environment variables
([#15971](#15971))

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix path in generated env.d.ts on Windows

2 participants