Skip to content

fix: ensure Netlify ambient types work#16255

Merged
teemingc merged 2 commits into
version-3from
fix-netlify-ambient-types
Jul 7, 2026
Merged

fix: ensure Netlify ambient types work#16255
teemingc merged 2 commits into
version-3from
fix-netlify-ambient-types

Conversation

@teemingc

@teemingc teemingc commented Jul 7, 2026

Copy link
Copy Markdown
Member

@netlify/functions should be a dep because we use it in the ambient types we ship. Similar to the Cloudflare worker types we use in the Cloudflare adapter. When it's a dev dep, the package is missing for users and the type will be any


Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

@pkg-svelte-dev

pkg-svelte-dev Bot commented Jul 7, 2026

Copy link
Copy Markdown

Install the latest version of @sveltejs/kit from 1b40c5d:

pnpm add https://pkg.svelte.dev/@sveltejs/kit/c/1b40c5d0188798e6b649314e26b9ff12fed264d2

Open in pkg.svelte.dev: https://pkg.svelte.dev/repos/kit/pr/16255

@changeset-bot

changeset-bot Bot commented Jul 7, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 1b40c5d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-netlify Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Comment on lines -54 to -55
"@netlify/node-cookies": "^0.1.0",
"@netlify/types": "^2.3.0",

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two deps have been unused by us for a while now so they're just orphans here

Comment thread pnpm-workspace.yaml
Comment on lines +50 to +51
'@netlify/dev': ^4.18.9
'@netlify/edge-functions': ^3.0.8

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped these versions so that they don't pull in duplicate packages from version discrepancies with @netlify/functions

@svelte-docs-bot

Copy link
Copy Markdown

@teemingc teemingc merged commit 9fc633d into version-3 Jul 7, 2026
18 checks passed
@teemingc teemingc deleted the fix-netlify-ambient-types branch July 7, 2026 16:03
Rich-Harris pushed a commit that referenced this pull request Jul 8, 2026
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to version-3, this PR
will be updated.

⚠️⚠️⚠️⚠️⚠️⚠️

`version-3` is currently in **pre mode** so this branch has prereleases
rather than normal releases. If you want to exit prereleases, run
`changeset pre exit` on `version-3`.

⚠️⚠️⚠️⚠️⚠️⚠️

# Releases
## @sveltejs/kit@3.0.0-next.7

### Major Changes

- breaking: change `form.error` type from `any` to `App.Error |
undefined` ([#16245](#16245))

- feat: allow adapters to provide additional Vite plugins
([#16206](#16206))

- breaking: move tracing out of the experimental namespace and remove
the instrumentation flag
([#16260](#16260))

- breaking: remove `$app/stores`
([#15499](#15499))

- breaking: disallow `*.remote.ts/js` files unless
`experimental.remoteFunctions` is enabled
([#16247](#16247))

- breaking: remove param files in folder in favor of `params.js/ts` file
([#16189](#16189))

### Patch Changes

- fix: defer `query.refresh()` in server commands until after the
command body completes
([#16225](#16225))

- fix: resolve service worker and `tsconfig.json` based on Vite `root`
setting ([#16229](#16229))

- fix: populate `$app/env/*` dynamic variables in contexts that don't
run the dev server, such as `vite-node`
([#16223](#16223))

- fix: no longer throw "An impossible situation occurred" when a
server-only module is imported by both server and client code
([#16257](#16257))

- fix: set `define` values on `globalThis` when running Vitest
([#16246](#16246))

- fix: serve `.ico` files with `image/x-icon` Content-Type
([#16234](#16234))

- fix: make `paths.origin` type looser
([#16215](#16215))

- fix: avoid client build warning about externalising `node:async_hooks`
([#16244](#16244))

- fix: allow reserved words (e.g. `delete`, `class`) as remote function
export names ([#16264](#16264))
## @sveltejs/adapter-netlify@7.0.0-next.2

### Patch Changes

- fix: ensure types for `platform.context` work
([#16255](#16255))
- Updated dependencies
[[`ba78a0b`](ba78a0b),
[`a248c9b`](a248c9b),
[`7596981`](7596981),
[`be72ed9`](be72ed9),
[`a5bd7e2`](a5bd7e2),
[`dec671f`](dec671f),
[`82f3867`](82f3867),
[`97eb324`](97eb324),
[`e2a9ac0`](e2a9ac0),
[`309bfb4`](309bfb4),
[`522a86b`](522a86b),
[`0ff547f`](0ff547f),
[`3d4ff91`](3d4ff91),
[`c925f2a`](c925f2a),
[`7daf445`](7daf445)]:
  - @sveltejs/kit@3.0.0-next.7

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants