moving a `.svelte` file incorrectly updates relative imports

[teemingc]

Describe the bug

Whenever I move a .svelte file, any import that uses a relative path such as ./$types (which is common in sveltekit) gets automatically updated to something incorrect.

Currently, there is no option to turn off automatic import updates, when moving a .svelte file, to avoid this problem.

Ideally, there would be options for prompt, always, and never similar to the TypeScript extension setting typescript.updateImportsOnFileMove.enabled.

Reproduction

Before moving from src/routes/a/b:

After moving to src/routes/b:

Expected behaviour

It should either resolve to the correct relative path, or not change it at all (if updating is disabled).

I don't think there's a way to keep SvelteKit generated types as './$types' as it doesn't exist until the types are generated again.

System Info

• OS: macOS Monterey 12.5.1 (21G83)
• IDE: VSCode

Which package is the issue about?

No response

Additional Information, eg. Screenshots

No response

[dummdidumm]

For ./$types: Strictly speaking this is the correct behavior - the import is updated to the previous location. In this specific case though it's undesired because you of course want to continue referencing the relative ./$types. Not sure if we can find a good way to make this work reliably, it's probably a heuristic.

For the other import: This indeed looks like a wrong import update

[williamviktorsson]

Perhaps related.. I experience an inconsistency when accepting import suggestions. Is it possible for ActionData/PageData and other similar imports to always suggest './$types' rather than .svelte-kit/types/src/.../$types' :-) ?

[dummdidumm]

This is unrelated, please open a new issue for that with more details. We implemented something for autocompletion to address this already, but maybe it has some rough edges.

[williamviktorsson]

This is unrelated, please open a new issue for that with more details. We implemented something for autocompletion to address this already, but maybe it has some rough edges.

Thank you. Will do if I can figure out in what cases it happens.

[teemingc]

Perhaps related.. I experience an inconsistency when accepting import suggestions. Is it possible for ActionData/PageData and other similar imports to always suggest './$types' rather than .svelte-kit/types/src/.../$types' :-) ?

I have opened a PR for that here sveltejs/kit#6642