Make on:sveltekit:xy events optional #1003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dogagenc
changed the title
Member
|
Silly me, thanks for the catch! |
dummdidumm
pushed a commit
to dummdidumm/language-tools
that referenced
this pull request
May 13, 2021
Against accidentally adding required props on intrinsic elements which have caught the error fixed in sveltejs#1003
dummdidumm
added a commit
that referenced
this pull request
May 13, 2021
Against accidentally adding required props on intrinsic elements which would have caught the error fixed in #1003
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest version of svelte2tsx requires
on:sveltekit:xyevents which breaks applications that use<svelte:window>without on:sveltekit:xy events.I have made those events optional.