(breaking) be more strict with required props #1030
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change now always marks properties as required if they have no initializer. Previously this was only the case when using TypeScript with strict mode. For this to work for both TS and JS files, the transformation in svelte2tsx was adjusted.
#319
#847
This is a breaking change
The fix is to provide a default value for properties that are optional. That's either the specific value kind or
undefined.Example TS:
export let optional: string;Becomes
export let optional: string = '';(or justexport let optional = '')Example JS:
export let optional;Becomes
export let optional = undefined;