Skip to content

Conversation

@dummdidumm
Copy link
Member

  • normalize paths, as it's not guaranteed that they are in the same format coming from different sources
  • deduplicate snapshots by introducing a global snapshot manager. A snapshot is unique across all services. If a snapshot is updated, that update should be reflected in all services

#1037

- normalize paths, as it's not guaranteed that they are in the same format coming from different sources
- deduplicate snapshots by introducing a global snapshot manager. A snapshot is unique across all services. If a snapshot is updated, that update should be reflected in all services

sveltejs#1037
@dummdidumm dummdidumm requested a review from jasonlyu123 June 1, 2021 10:14
Copy link
Member

@jasonlyu123 jasonlyu123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@dummdidumm dummdidumm merged commit 0d9e577 into sveltejs:master Jun 1, 2021
@dummdidumm dummdidumm deleted the deduplicate-snapshots branch June 1, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants