fix binding/ shorthand props rename #1087
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#969
Marking as a draft for now because I want to check what's the edge case I'm encountering before. Can't quite remember the problem and didn't found many problems now in the latest commit.The problem probably is whengetAdditionalLocationsForRenameOfPropInsideOtherComponentreturns the same rename as the original rename. When that happens the duplicate one is not checked thus there are some overlapping rename locations. Since renaming props might also need the check for the shorthand, I also apply the check to other files.I also find another rename problem when props having
__sveltets_1_anyinjected behind declaration in svelte2tsx. Maybe we can fix that in a separate PR.