(fix) prevent crash on some language client with unknown code action kind #1488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto code-action-client-support
dummdidumm
approved these changes
May 17, 2022
Member
dummdidumm
left a comment
dummdidumm
left a comment
There was a problem hiding this comment.
I'm okay with this change 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the sort import version is released. I saw my side project language client for the visual studio crash because of the unknown CodeActionKind. I hesitate to fix it here as the protocol did specify that the language-server client should not panic when there's an unknown
CodeActionKindbut I can't find a way to fix it on my side.This adds a initialize option to force the server to filter out code actions the client doesn't support. If another client also has a similar problem they could also pass this option to fix the problem. Didn't choose to only filter out the "sort import". Because it might throw another error once there's a new one that it's not yet supported in the future.
@dummdidumm What do you think about this?