(feat) css path completion #1533
Conversation
dummdidumm
left a comment
dummdidumm
left a comment
There was a problem hiding this comment.
Nice! Left some minor comments/questions
| isSymbolicLink(): boolean; | ||
| } | ||
|
|
||
| export class FileSystemProvider implements CSSFileSystemProvider { |
There was a problem hiding this comment.
You added this to lib and it's only used inside plugins/css. What's the reason for this? Do you think this could be useful outside the CSS plugin, too, or that it's not directly connected to the CSS plugin?
There was a problem hiding this comment.
vscode-html-languageservice has the same API for path completion. Originally I was thinking maybe we can add it too. But I am not sure is useful inside a svelte file. Since most of the time, the relative path to an asset does work like plain HTML. I think I'll move it to plugins/css for now. We could move it out if we want to use it in HTML later.
| }; | ||
| } | ||
|
|
||
| private UnknownStat(): FileStat { |
|
|
||
| // adopted from https://github.com/microsoft/vscode/blob/5ffcfde11d8b1b57634627f5094907789db09776/extensions/css-language-features/server/src/utils/documentContext.ts | ||
|
|
||
| import { DocumentContext } from 'vscode-css-languageservice'; |
There was a problem hiding this comment.
Same question like in FileSystemProvider
| return langs[lang]; | ||
| } | ||
|
|
||
| export function getLanguageServices(options?: LanguageServiceOptions): CSSLanguageServices { |
There was a problem hiding this comment.
createLanguageServices is a better name I think
we can move it out later if it's needed elsewhere
2 participants
#1505
implemented a
FileSystemProviderthevscode-css-languageerviceexpected to support path completion. TheDocuementContextis adopted from the vscode source. And theFileSystemProviderhas some differences with the implementation of vscode but I adopted the error handling.