Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): add "off" to data-sveltekit-noscroll and data-sveltekit-reload props definitions #1749

Merged
merged 1 commit into from
Dec 1, 2022

Conversation

oekazuma
Copy link
Contributor

@oekazuma oekazuma commented Dec 1, 2022

The data-sveltekit-noscroll and data-sveltekit-reload props should be allowed to be "off".

Definition of data-sveltekit-noscroll
https://github.com/sveltejs/kit/blob/e2c74b7278ed75de681dfbbe84969c6cc318660c/packages/kit/src/runtime/client/utils.js#L34

Definition of data-sveltekit-reload
https://github.com/sveltejs/kit/blob/e2c74b7278ed75de681dfbbe84969c6cc318660c/packages/kit/src/runtime/client/utils.js#L35

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@dummdidumm dummdidumm merged commit 4b437e0 into sveltejs:master Dec 1, 2022
@oekazuma oekazuma deleted the fix-sveltekit-anchor-props branch December 1, 2022 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants