(feat) autoImportFileExcludePatterns config support #1818
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dummdidumm
approved these changes
Jan 9, 2023
Member
dummdidumm
left a comment
dummdidumm
left a comment
There was a problem hiding this comment.
Nice! I'd wait a little longer before adding any defaults. Did you see other instances of this discord question (meaning that a lot of people run into this issue)?
Member
Author
|
At least one more. Another solution is to deprioritize |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added in typescript 4.8 https://devblogs.microsoft.com/typescript/announcing-typescript-4-8/#exclude-specific-files-from-auto-imports
The pattern normalization part is adopted from VSCode. But I found leading wildcard patterns don't work in Windows. It does work in Ubuntu WSL. So I changed it also to append workspace root. (Noted to self, should open an issue on either VSCode or TypeScript to ask about it)
Also, should we default some SvelteKit files with this config? Like
+error.{svelte,ts,js}. Seen someone in the discord a few times accidentally trigger auto import when trying to throw an error.https://discord.com/channels/457912077277855764/1053932682955997234/1053932682955997234