Skip to content

fix: revert waiting for config request in ts plugin #2352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2024
Merged

fix: revert waiting for config request in ts plugin #2352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions packages/typescript-plugin/src/config-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,13 @@ export class ConfigManager {
}

updateConfigFromPluginConfig(config: Configuration) {
const shouldWaitForConfigRequest = config.global == true;
const enable = config.enable ?? !shouldWaitForConfigRequest;
// TODO this doesn't work because TS will resolve/load files already before we get the config request,
// which leads to TS files that use Svelte files getting all kinds of type errors
// const shouldWaitForConfigRequest = config.global == true;
// const enable = config.enable ?? !shouldWaitForConfigRequest;
this.config = {
...this.config,
...config,
enable
...config
};
this.emitter.emit(configurationEventName, config);
}
Expand Down