feat: implement 'source.removeUnusedImports' code action #2875
+138
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5ed0114 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jasonlyu123
reviewed
Oct 29, 2025
There was a problem hiding this comment.
We still need to register the source action kind in the LSP server capability here
language-tools/packages/language-server/src/server.ts
Lines 272 to 276 in 6ad05e5
We also need a changeset for this. You can run pnpx @changesets/cli in the repo root and follow the prompt.
packages/language-server/src/plugins/typescript/features/CodeActionsProvider.ts
Show resolved
Hide resolved
…nto pr/craig-jennings/2875
jasonlyu123
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more to get the ball rolling as I'm sure I missed something. This updates the
organizeImportsfunction to use themodeparameter rather than the deprecatedskipDestructiveCodeActionsone. It also adds a test to ensure that unused imports are removed while maintaining the order of the imports.Fixes #2838