Skip to content

Conversation

@jasonlyu123
Copy link
Member

fix for #310 and better union type for template

<script>
let a: 'a' | 'b' = 'a';

const handler = () => {
  a = 'b'
}
</script>

{ a } <!-- a will have type 'a' | 'b' now -->

@jasonlyu123
Copy link
Member Author

jasonlyu123 commented Jul 16, 2020

Since it'll affect the "most-discussed-problem", the reactive declaration, This will be blocked until a better solution for both problems.

@jasonlyu123
Copy link
Member Author

Umm... Why are there so many merging conflicts when the edit is on the different line lol

@jasonlyu123 jasonlyu123 merged commit 8e3c8b5 into sveltejs:master Jul 29, 2020
dummdidumm pushed a commit to dummdidumm/language-tools that referenced this pull request Jul 31, 2020
The changes done in sveltejs#363 can be reverted because the bug which the PR was fixing (sveltejs#338) is also fixed through sveltejs#314
sveltejs#400

Revert "fix bind:this used before assign (sveltejs#363)"

This reverts commit 5348104.
dummdidumm added a commit that referenced this pull request Jul 31, 2020
* (fix) make bind:this understand specific element type again

The changes done in #363 can be reverted because the bug which the PR was fixing (#338) is also fixed through #314
#400

Revert "fix bind:this used before assign (#363)"

This reverts commit 5348104.

* fix rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant