(fix) allow empty initializationOptions #411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch, thanks! |
martinxyz
added a commit
to martinxyz/language-tools
that referenced
this pull request
Aug 30, 2020
initializationOptions was null (it's optional but the vscode client always sets it), which resulted in this traceback: TypeError: Cannot read property 'svelte' of undefined + at LSConfigManager.update (.../dist/src/ls-config.js:61:46) + at PluginHost.updateConfig (.../PluginHost.js:29:21) ...snip... Fixes regression from sveltejs#411
dummdidumm
pushed a commit
that referenced
this pull request
Aug 30, 2020
initializationOptions was null (it's optional but the vscode client always sets it), which resulted in this traceback: TypeError: Cannot read property 'svelte' of undefined + at LSConfigManager.update (.../dist/src/ls-config.js:61:46) + at PluginHost.updateConfig (.../PluginHost.js:29:21) ...snip... Fixes regression from #411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to start the language server with empty
initializationOptions. Right now it throws an errorCannot read property 'dontFilterIncompleteCompletions' of null (Internal Error)