Skip to content

Conversation

@dummdidumm
Copy link
Member

Highlights moustache tags properly when the tag spans multiple lines
#478, #381

This fix looks suspicously simple, so it would be great if you could have a look at this @jasonlyu123 😄

Highlights moustache tags properly when the tag spans multiple lines
sveltejs#478, sveltejs#381
@jasonlyu123
Copy link
Member

Ummm... I didn't found any downside to this either. Seems like that part of the regex is not needed.

@dummdidumm
Copy link
Member Author

Alright, then it really must be that simple 😄 Thanks for looking into it!

@jasonlyu123
Copy link
Member

jasonlyu123 commented Aug 26, 2020

Feel dumb to have spent 40 minutes trying to make it match \\b([a-zA-Z\\-_:]+)=(\"|')(?=(.|\\s)*{ 🤣

@dummdidumm dummdidumm merged commit fb1012b into sveltejs:master Aug 26, 2020
@dummdidumm dummdidumm deleted the fix-moustache-highlighting branch August 26, 2020 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants