Skip to content

(fix) take .prettierignore into account #506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 31, 2020
Merged

(fix) take .prettierignore into account #506

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
342dfcd
(fix) take .prettierignore into account
Aug 30, 2020
7bd245e
lint
Aug 30, 2020
555e8bc
fall back to `.prettierignore`
Aug 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/language-server/src/plugins/svelte/SveltePlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ import { getCompletions } from './features/getCompletions';
import { getDiagnostics } from './features/getDiagnostics';
import { getHoverInfo } from './features/getHoverInfo';
import { SvelteCompileResult, SvelteDocument } from './SvelteDocument';
import { Logger } from '../../logger';

export class SveltePlugin
implements
Expand Down Expand Up @@ -67,6 +68,15 @@ export class SveltePlugin
// Try resolving the config through prettier and fall back to possible editor config
const config =
(await prettier.resolveConfig(filePath, { editorconfig: true })) || this.prettierConfig;
// Take .prettierignore into account
const fileInfo = await prettier.getFileInfo(filePath, {
ignorePath: this.prettierConfig?.ignorePath ?? '.prettierignore',
});
if (fileInfo.ignored) {
Logger.log('File is ignored, formatting skipped');
return [];
}

const formattedCode = prettier.format(document.getText(), {
...config,
plugins: getSveltePlugin(),
Expand Down