(fix) try to be smarter about unclosed tags #578
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tries to parse the HTML document and work around the limitations of the underlying parser which will trip up when there's a non-closed tag and treat everything afterwards as its child. sveltejs#547
dummdidumm
pushed a commit
to dummdidumm/language-tools
that referenced
this pull request
Oct 29, 2020
- Parser got better: Now sees `<` as start of other opening tag. sveltejs#547, closes sveltejs#578 - New option to not provide default data provider which removes duplicate suggestions
dummdidumm
added a commit
that referenced
this pull request
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to parse the HTML document and work around the limitations of the underlying parser which will trip up when there's a non-closed tag and treat everything afterwards as its child.
#547
Since this feels pretty hacky I'll leave this open a bit for others to have a look.