-
-
Notifications
You must be signed in to change notification settings - Fork 223
feat: CLI argument --fail-on-hints #582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the PR! Could you also update the writer's |
|
Also in the machine output? |
|
Yes |
b1e549f to
5d03237
Compare
|
I've refactored the completion method, going from 4 to 8 variations: to: |
|
I think at this point it might make sense - also from a maintenance perspective - to simplify this to |
5d03237 to
5c85cc8
Compare
5c85cc8 to
615497a
Compare
| // Event Handler Types | ||
| // ---------------------------------------------------------------------- | ||
| type EventHandler<E = Event, T = HTMLElement> = (event: E & { currentTarget: EventTarget & T}) => any; | ||
| type EventHandler<E = Event, T = HTMLElement> = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line was 102 characters, creating a linting error.
|
Simplified |
dummdidumm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Feature
svelte-check --fail-on-hintswill exit with error code when there are hints, similar to--fail-on-warningsUse case
I want my CI and commit hooks to fail when there are hints, that way I can prevent committing code with hints such as: