Skip to content

(fix) more missing attributes #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 21, 2020
Merged

(fix) more missing attributes #629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0af2e17
add indeterminate attribute
jasonlyu123 Oct 21, 2020
3283ffc
ismap for img
jasonlyu123 Oct 21, 2020
a913d68
allowpaymentrequest
jasonlyu123 Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion packages/language-server/src/plugins/html/dataProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,11 +245,18 @@ const videoAttributes: IAttributeData[] = [
}
];

const indeterminateAttribute: IAttributeData = {
name: 'indeterminate',
description: 'Available for type="checkbox"'
};

const addAttributes: Record<string, IAttributeData[]> = {
select: [{ name: 'bind:value' }],
input: [
{ name: 'bind:value' },
{ name: 'bind:group', description: 'Available for type="radio" and type="checkbox"' }
{ name: 'bind:group', description: 'Available for type="radio" and type="checkbox"' },
indeterminateAttribute,
{...indeterminateAttribute, name: 'bind:indeterminate'}
],
textarea: [{ name: 'bind:value' }],
video: [...mediaAttributes, ...videoAttributes],
Expand Down
3 changes: 3 additions & 0 deletions packages/svelte2tsx/svelte-jsx.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ declare namespace svelte.JSX {
allow?: string;
allowfullscreen?: boolean;
allowtransparency?: boolean;
allowpaymentrequest?: boolean;
alt?: string;
async?: boolean;
autocomplete?: string;
Expand Down Expand Up @@ -296,6 +297,7 @@ declare namespace svelte.JSX {
inputmode?: string;
integrity?: string;
is?: string;
ismap?: boolean;
keyparams?: string;
keytype?: string;
kind?: string;
Expand Down Expand Up @@ -685,6 +687,7 @@ declare namespace svelte.JSX {
interface SvelteInputProps extends HTMLProps<HTMLInputElement> {
group?: any;
files?: FileList | null;
indeterminate?: boolean;
}

interface SvelteWindowProps {
Expand Down