Skip to content

Conversation

@dummdidumm
Copy link
Member

This PR fixes the bugs I mentioned in #657

  • Fix special svelte attributes highlighting by listing them out instead of using a generic \w+ regex. No longer treats "superon:click" as a special svelte attribute and highlights accordingly.
  • Fix highlighting for empty style/script/template tag by adding a "not immediately followed by </" condition to the begin regex.

@Monkatraz @jasonlyu123 could you have a look?

Simon Holthausen added 2 commits November 19, 2020 10:13
Fix special svelte attributes highlighting by listing them out instead of using a generic \w+ regex. No longer treats "superon:click" as a special svelte attribute and highlights accordingly.
… immediately followed by </" condition to the begin regex.
@dummdidumm dummdidumm merged commit e3fd41c into sveltejs:master Nov 24, 2020
@dummdidumm dummdidumm deleted the fix-grammar branch November 24, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants