Skip to content

(fix) dont show redundant onevent completions #907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 23, 2021
Merged

(fix) dont show redundant onevent completions #907

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/language-server/src/plugins/typescript/features/CompletionProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,5 +476,11 @@ function isValidCompletion(
if (!isCompletionInHTMLStartTag) {
return () => true;
}
return (value) => !completionBlacklist.has(value.name);
return (value) =>
!completionBlacklist.has(value.name) &&
// remove attribues starting with "on" because those are events.
// Svelte wants events of the form "on:X", but the suggestions
// are of the form "onX". Moreover, they are doubled by the HTML
// attribute suggestions. Therefore filter them out.
!value.name.startsWith('on');
}