Skip to content
This repository was archived by the owner on Jan 11, 2023. It is now read-only.
This repository was archived by the owner on Jan 11, 2023. It is now read-only.

Drop source-map-support? #366

@Rich-Harris

Description

@Rich-Harris

Currently, source-map-support is installed by default when you use the middleware. This probably doesn't make sense. It is useful to have sourcemapped stack traces (notwithstanding that it doesn't currently apply to components — see #117), but the middleware feels like the wrong place for it.

A few options:

  • Expect app authors to include it (and put it in sapper-template)
  • Keep it, but only activate if process.env.NODE_ENV is 'development' (not sure if there's really much point to that)
  • Add it in dev mode via sapper dev (if that's possible, given that it's a child process?)
  • Scrap it, and handle errors in the child process differently inside sapper dev

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions