This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Pull request to resolve issue #1442 #1200
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#1142 Route with address "/client/" is not working. The first request to any route under "/client" - for instance "http://localhost/client/new" - would incorrectly get past the filter function at [`req.start.startsWith(prefix)`](https://github.com/sveltejs/sapper/blob/facbd96e0bd2539acf32c5ac14cd9478c7c635e5/runtime/src/server/middleware/index.ts#L104). Fix: add an extra test in the filter, whether there is a dot present in the requested path. Reasoning: I assume all the content served by sapper has an extension, such as "/client/chunk_slug.js". As well I assume there aren't requests to paths both startign with "/client" _and_ containing a dot, such as "http://localhost/client/new.123". That would still result in a 404.
Member
|
@jervtub I don't quite understand how you're differentiating. Doesn't I'm not sure it's a good idea to try to differentiate by file name. I prefer the approach that @Conduitry suggested #1142 (comment) |
Member
|
@jervtub just checking in on this PR. Are you still interested in pursuing it? Did you have any thoughts about my question? |
4 tasks
Member
|
Closing in favor of #1307 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1142
Route with address "/client/" is not working.
The first request to any route under "/client" - for instance "http://localhost/client/new" - would
incorrectly get past the filter function at
req.start.startsWith(prefix).Fix: add an extra test in the filter, whether there is a dot present in the
requested path.
Reasoning:
I assume all the content served by sapper has an extension, such as "/client/chunk_slug.js".
As well I assume there aren't requests to paths both startign with
"/client" and containing a dot, such as "http://localhost/client/new.123". That would still result in a 404.