This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Support better stack trace with sourcemaps #1357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
reviewed
Aug 4, 2020
Member
benmccann
left a comment
benmccann
left a comment
There was a problem hiding this comment.
thanks so much for picking this PR up!
| } | ||
| ); | ||
|
|
||
| file_cache.clear(); |
Member
There was a problem hiding this comment.
I'm not really sure what the point of the file_cache is if it's cleared everytime we try to source map an exception
Contributor
Author
There was a problem hiding this comment.
I noticed that in a stack trace, sometimes you can hit the same file with different lines and cols. The file_cache there is just a means to avoid rereading that file multiple times in a single call to sourcemap_stacktrace.
Member
|
@habibrosyad this PR will need to be rebased |
Contributor
Author
|
@benmccann done... |
antony
approved these changes
Aug 7, 2020
Member
antony
left a comment
antony
left a comment
There was a problem hiding this comment.
This is brilliant. Makes diagnosing server-errors easy. Thank you!
trmcnvn
pushed a commit
to metafy-gg/sapper
that referenced
this pull request
Aug 15, 2020
Co-authored-by: Teoxoy <28601907+Teoxoy@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a continuity of #773 by adding test and fix found issues.
Closes #117
Closes #773
Before submitting the PR, please make sure you do the following
npm run lint!)Tests
npm testoryarn test)