This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Code cleanup #1392
Merged
Code cleanup #1392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benmccann
force-pushed
the
code-cleanup
branch
from
6f1a6aa to
c6eeadc
Compare
antony
approved these changes
Aug 11, 2020
Member
antony
left a comment
antony
left a comment
There was a problem hiding this comment.
Agreed to merge, it's a much better experience for contributors.
trmcnvn
pushed a commit
to metafy-gg/sapper
that referenced
this pull request
Aug 15, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1198 is getting really out of date. It might be helpful to merge the obvious cleanups like missing semi-colons and then do another PR to apply @antony's plugin and fix the remaining errors. I think it'll be a lot easier that way than trying to do one really big bang