Skip to content

Conversation

@baseballyama
Copy link
Member

close: #799

@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2025

🦋 Changeset detected

Latest commit: d5efd03

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/svelte-eslint-parser@d5efd03

Published Instant Preview Packages:

View Commit

@coveralls
Copy link

coveralls commented Dec 3, 2025

Pull Request Test Coverage Report for Build 19899024867

Details

  • 4 of 5 (80.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.006%) to 94.711%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/html.ts 2 3 66.67%
Totals Coverage Status
Change from base Build 19895901968: -0.006%
Covered Lines: 10684
Relevant Lines: 11157

💛 - Coveralls

@baseballyama baseballyama marked this pull request as ready for review December 3, 2025 15:25
Copilot AI review requested due to automatic review settings December 3, 2025 15:25
Copilot finished reviewing on behalf of baseballyama December 3, 2025 15:27
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for the name_loc property required by Svelte 5.45.3+ to fix issue #799. The implementation sets name_loc to null across all Attribute objects in the parser.

  • Upgrades Svelte dependency from 5.41.0 to 5.45.4
  • Adds name_loc: null property to all Attribute objects
  • Updates test snapshots to reflect the new property

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/parser/html.ts Adds name_loc: null to all three Attribute object creation points in the parseAttribute function
src/parser/compat.ts Adds name_loc: null to SvelteOptions object with a TypeScript error suppression comment
tests/src/parser/snapshots/html.ts.snap Updates all test snapshots to include the new name_loc: null property in Attribute objects
package.json Updates Svelte dependency from ^5.41.0 to ^5.45.4
pnpm-lock.yaml Updates lockfile to reflect Svelte version change and related dependency updates (esrap, devalue)
.changeset/wet-carrots-open.md Adds changeset documenting this patch-level fix
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@ota-meshi ota-meshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ota-meshi ota-meshi merged commit e1b92c0 into main Dec 4, 2025
18 checks passed
@ota-meshi ota-meshi deleted the fix/name_loc branch December 4, 2025 00:06
@benmccann
Copy link
Member

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update svelte to latest version and add name_loc property

5 participants