-
-
Notifications
You must be signed in to change notification settings - Fork 26
fix: Support name_loc property
#801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: d5efd03 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
7a92d01 to
d5efd03
Compare
Try the Instant Preview in Online PlaygroundInstall the Instant Preview to Your LocalPublished Instant Preview Packages:
|
Pull Request Test Coverage Report for Build 19899024867Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for the name_loc property required by Svelte 5.45.3+ to fix issue #799. The implementation sets name_loc to null across all Attribute objects in the parser.
- Upgrades Svelte dependency from 5.41.0 to 5.45.4
- Adds
name_loc: nullproperty to all Attribute objects - Updates test snapshots to reflect the new property
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/parser/html.ts | Adds name_loc: null to all three Attribute object creation points in the parseAttribute function |
| src/parser/compat.ts | Adds name_loc: null to SvelteOptions object with a TypeScript error suppression comment |
| tests/src/parser/snapshots/html.ts.snap | Updates all test snapshots to include the new name_loc: null property in Attribute objects |
| package.json | Updates Svelte dependency from ^5.41.0 to ^5.45.4 |
| pnpm-lock.yaml | Updates lockfile to reflect Svelte version change and related dependency updates (esrap, devalue) |
| .changeset/wet-carrots-open.md | Adds changeset documenting this patch-level fix |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ota-meshi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
Thank you!! |
close: #799