Skip to content

Conversation

@looshch
Copy link
Contributor

@looshch looshch commented Oct 26, 2024

Make the casing of the word ‘DOM’ in the Svelte 5 migration guide consistent.

#13957

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Make the casing of the word ‘DOM’ in the Svelte 5 migration guide
consistent.
@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2024

⚠️ No Changeset found

Latest commit: a64a6cb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@benmccann benmccann changed the title docs: the Svelte 5 migration guide (#13957) docs: consistently capitalize DOM in the Svelte 5 migration guide (#13957) Oct 26, 2024
@looshch
Copy link
Contributor Author

looshch commented Oct 26, 2024

@benmccann thanks for the approval! Based on your change to the PR title, should i update the first line of my commit as well? It has a full description in the commit body, but i’m not sure what’s the Svelte’s approach on commit titles

@benmccann benmccann merged commit 5ab65e3 into sveltejs:main Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants