Skip to content

Conversation

@snide
Copy link
Contributor

@snide snide commented Oct 30, 2024

This is my first PR in the docs. I'd like to contribute more, so please be easy on me. I noticed the in and out docs wouldn't work without the correct import from transition. This will make it a bit obvious.

@changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2024

⚠️ No Changeset found

Latest commit: 4d2f1fb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@Rich-Harris Rich-Harris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There's basically one of two ways you can go here — everything can be implicit, or it can be explicit. Previously it was implicit because these docs previously lived directly alongside the transition: docs, but I agree that it doesn't really make sense that way.

But if it's explicit, then we need to make everything explicit, otherwise people will copy the code into the playground and then be confused that it doesn't work. To that end, I added the visible state and a toggle that controls it.

@Rich-Harris Rich-Harris merged commit ee2f4a2 into sveltejs:main Oct 30, 2024
8 checks passed
@pkg-pr-new
Copy link

pkg-pr-new bot commented Oct 30, 2024

pnpm add https://pkg.pr.new/svelte@14050

commit: 4d2f1fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants