chore: exclude vite optimized deps from stack traces#17008
Merged
dummdidumm merged 1 commit intomainfrom Oct 22, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: 844adaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
dummdidumm
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
quick follow-up to #17001. We remove Svelte internals from the stack trace so that you only see user code, which makes it much easier to find the source of a change. But the heuristic we use for 'Svelte internals' is that the line includes 'svelte/src/internal', which doesn't work if the code has been bundled.
Unfortunately, that's usually the case, because Vite will bundle stuff in
node_modulesunless you tell it not to. We can account for that by also excludingnode_modules/.vite. It won't fix every setup but it fixes the most common case.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint