Skip to content

Conversation

@dummdidumm
Copy link
Member

Not all batches will flush right after being activated, some will be activated and then get is called on a signal. In that case the value was wrong because we did not apply the changes of that batch. By doing this.apply() during activate() we ensure we do, which fixes (among other things, likely) a forking bug where old values where sneaking in.

Fixes #17079

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

Not all batches will flush right after being activated, some will be activated and then `get` is called on a signal. In that case the value was wrong because we did not apply the changes of that batch. By doing `this.apply()` during `activate()` we ensure we do, which fixes (among other things, likely) a forking bug where old values where sneaking in.

Fixes #17079
@changeset-bot
Copy link

changeset-bot bot commented Nov 2, 2025

🦋 Changeset detected

Latest commit: b3b6f0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 2, 2025

Playground

pnpm add https://pkg.pr.new/svelte@17098

Co-authored-by: Rich Harris <rich.harris@vercel.com>
@dummdidumm dummdidumm merged commit eea8a18 into main Nov 3, 2025
14 of 16 checks passed
@dummdidumm dummdidumm deleted the fork-apply-fix branch November 3, 2025 20:02
@github-actions github-actions bot mentioned this pull request Nov 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

params becomes empty object ({}) after any async work

3 participants