-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix: wait on dependencies of async bindings #17120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: bf356a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
Testing this. This works: <script lang="ts">
await Promise.resolve();
let search = $state("test");
</script>
<input type="text" bind:value={search} />This does not: <script lang="ts">
await Promise.resolve();
let search = $state({ query: "test" });
</script>
<!-- works if you remove the binding below or the await above -->
<!-- also works if you move the await after the `$state()` -->
<!-- Cannot read properties of undefined (reading 'query') -->
<input type="text" bind:value={search.query} /> |
|
Thank you for the test! Uncovered a dev-only bug with validation (it needed to wait on blockers, too) |
|
Found this was wrong for style directives, too |
Rich-Harris
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so glad you figured all this out so i didn't have to 😆
Correctly takes into account blockers for bindings. Also ensures it works for functional bindings.
During that I also noticed a bug in our
nodes_endassignment logic, which the added test also regresses against.Fixes #17092
Fixes #17090
Also discovered a related bug with static props also not awaiting the blockers, which is also fixed in this PR
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint