fix: wait on dependencies of async bindings#17120
Merged
Rich-Harris merged 5 commits intomainfrom Nov 7, 2025
Merged
Conversation
🦋 Changeset detectedLatest commit: bf356a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
|
Testing this. This works: <script lang="ts">
await Promise.resolve();
let search = $state("test");
</script>
<input type="text" bind:value={search} />This does not: <script lang="ts">
await Promise.resolve();
let search = $state({ query: "test" });
</script>
<!-- works if you remove the binding below or the await above -->
<!-- also works if you move the await after the `$state()` -->
<!-- Cannot read properties of undefined (reading 'query') -->
<input type="text" bind:value={search.query} /> |
Member
Author
|
Thank you for the test! Uncovered a dev-only bug with validation (it needed to wait on blockers, too) |
Member
Author
|
Found this was wrong for style directives, too |
This was referenced Nov 6, 2025
Rich-Harris
approved these changes
Nov 7, 2025
Member
Rich-Harris
left a comment
There was a problem hiding this comment.
so glad you figured all this out so i didn't have to 😆
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correctly takes into account blockers for bindings. Also ensures it works for functional bindings.
During that I also noticed a bug in our
nodes_endassignment logic, which the added test also regresses against.Fixes #17092
Fixes #17090
Also discovered a related bug with static props also not awaiting the blockers, which is also fixed in this PR
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint