Skip to content

Conversation

@dummdidumm
Copy link
Member

There's a possibility of a race condition where batch.deactivate() is called while current_batch !== batch, and so it would deactivate another batch, which can lead to zombie batches that are never flushed, subsequently leading to wrong batch_values. This fixes that by checking if the current batch is the own batch.

Fixes #17109

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

There's a possibility of a race condition where `batch.deactivate()` is called while `current_batch !== batch`, and so it would deactivate another batch, which can lead to zombie batches that are never flushed, subsequently leading to wrong `batch_values`. This fixes that by checking if the current batch is the own batch.

Fixes #17109
@changeset-bot
Copy link

changeset-bot bot commented Nov 9, 2025

🦋 Changeset detected

Latest commit: 3ddfcbe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2025

Playground

pnpm add https://pkg.pr.new/svelte@17132

@Ocean-OS Ocean-OS merged commit 14b0926 into main Nov 11, 2025
17 of 18 checks passed
@Ocean-OS Ocean-OS deleted the batch-deactivate-fix branch November 11, 2025 05:55
@github-actions github-actions bot mentioned this pull request Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Async derived causes bind:this refs to revert to initial state when passed as props

3 participants